[Android] [Overflow Actions] Fix - Secondary Actions not rendered properly without primary actions #6319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A card has only secondary actions without any primary actions is not rendering correctly. This issue happens only if any one of the secondary action is a
ShowCard
action type.Fix
There may be a case where
Secondary Actions
can exist withoutPrimary Actions
, so to fix that size check is removed forPrimary Actions
. This ensures that the action layout container is added forSecondary Actions
even.Sample Card
How Verified
Please refer below after and before screenshots.
In the first action set ("Action Set : all Secondary Actions") elements,
Action.ShowCard
should be underOverflowAction
button and should not be shown as primary action.Microsoft Reviewers: Open in CodeFlow