Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom.props for release #6395

Merged
merged 5 commits into from
Sep 30, 2021
Merged

Update custom.props for release #6395

merged 5 commits into from
Sep 30, 2021

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Sep 22, 2021

Related Issue

Fixes #6351

Description

Update custom.props to set the UWP package version. Due to significant breaking changes in the UWP renderer (Object model namespace change, several properties changing type from foo to IReference<foo> (see #6354)), I have incremented the major version. Please holler if that doesn't seem right.

Microsoft Reviewers: Open in CodeFlow

@RebeccaAnne RebeccaAnne added this to In progress in Current Sprint via automation Sep 23, 2021
@RebeccaAnne RebeccaAnne moved this from In progress to Reviewer approved in Current Sprint Sep 23, 2021
@ghost ghost added the no-recent-activity label Sep 28, 2021
@ghost
Copy link

ghost commented Sep 28, 2021

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Sep 28, 2021
@ghost
Copy link

ghost commented Sep 28, 2021

Staleness reset by almedina-ms

Current Sprint automation moved this from Reviewer approved to Review in progress Sep 28, 2021
Copy link
Contributor

@almedina-ms almedina-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Current Sprint automation moved this from Review in progress to Reviewer approved Sep 29, 2021
@ghost ghost removed the Needs: Author Feedback label Sep 29, 2021
@jonmill jonmill merged commit 5376504 into main Sep 30, 2021
Current Sprint automation moved this from Reviewer approved to Done Sep 30, 2021
@jonmill jonmill deleted the rebecch/custompropsupdate branch September 30, 2021 17:52
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Co-authored-by: Jonathan Miller <jonmil@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Co-authored-by: Jonathan Miller <jonmil@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Update XAML package version for schema v1.5
5 participants