-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update custom.props for release #6395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaAnne
requested review from
paulcam206,
jwoo-msft,
almedina-ms and
jonmill
September 22, 2021 16:22
paulcam206
approved these changes
Sep 22, 2021
jwoo-msft
approved these changes
Sep 22, 2021
Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
almedina-ms
reviewed
Sep 28, 2021
ghost
removed
the
no-recent-activity
label
Sep 28, 2021
Staleness reset by almedina-ms |
almedina-ms
requested changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
ghost
added
the
Needs: Author Feedback
label
Sep 28, 2021
almedina-ms
approved these changes
Sep 29, 2021
ghost
removed
the
Needs: Author Feedback
label
Sep 29, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
Co-authored-by: Jonathan Miller <jonmil@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
Co-authored-by: Jonathan Miller <jonmil@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6351
Description
Update custom.props to set the UWP package version. Due to significant breaking changes in the UWP renderer (Object model namespace change, several properties changing type from
foo
toIReference<foo>
(see #6354)), I have incremented the major version. Please holler if that doesn't seem right.Microsoft Reviewers: Open in CodeFlow