-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Updated RichTextBlock wrap behavior #6399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
approved these changes
Sep 27, 2021
almedina-ms
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwoo-msft - looks like you have a merge conflict to fix up :) |
…nstraints that caused text to clipped
@paulcam206, i had to look into positional ambiguity with buttons. it's all fixed up. :-) |
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [iOS] Updated RichTextBlock wrap behavior * [iOS] Refactored ActionSet constraints and removed auxiliary width constraints that caused text to clipped
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [iOS] Updated RichTextBlock wrap behavior * [iOS] Refactored ActionSet constraints and removed auxiliary width constraints that caused text to clipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #6365.
Long RichTextBlock's text will get cut off unexpectedly when it's inside a column with shorter width.
Description
This change changed the order when the compression resistance is applied. Applying compression resistance after a view is added to UIStackView does not produce the desired effect. The change applies the compression resistance first, then added to the stack iew.
Sample Card
How Verified
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow