Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared] table update #6446

Merged
merged 3 commits into from
Sep 30, 2021
Merged

[shared] table update #6446

merged 3 commits into from
Sep 30, 2021

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Sep 29, 2021

Description

Added internal id assignment to TableRow & TableCell as need in iOS for vertical/horizontal content alignment and header row. Feel free to change the PR.

How Verified

Manually ran Table json to check for the above-mentioned properties.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@jwoo-msft jwoo-msft enabled auto-merge (squash) September 30, 2021 17:35
@paulcam206 paulcam206 merged commit e3d82a0 into main Sep 30, 2021
@paulcam206 paulcam206 deleted the jwoo/shared-table-update branch September 30, 2021 18:39
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants