Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Designer] Fix the card structure order problem #6457

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Conversation

licanhua
Copy link
Contributor

@licanhua licanhua commented Sep 30, 2021

Fix #6375
In the code, action is insert to the begin the tree, so for any cards with action, the order are messed up.
After the code change, the action is moved to the end.

Before
image

After
image

I did the manual testing, and will like if I can write automation for this

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Sep 30, 2021

Hi @licanhua. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@licanhua licanhua changed the title Fix the card structure order problem [Designer] Fix the card structure order problem Sep 30, 2021
@licanhua
Copy link
Contributor Author

Click this link to verify the change

Copy link
Contributor

@almedina-ms almedina-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor nits - good find!

@paulcam206 paulcam206 merged commit f0a1027 into main Oct 1, 2021
@paulcam206 paulcam206 deleted the canhua/cardstruct branch October 1, 2021 00:13
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* Fix the card structure order problem

* remove number from let

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Designer] Items in Card Structure pane are out of order
3 participants