[UWP] Input.Text password style support #6479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run uwp-ci.yml |
|
Azure Pipelines successfully started running 1 pipeline(s). |
almedina-ms
reviewed
Oct 5, 2021
source/uwp/AdaptiveCardsObjectModel/idl/AdaptiveCards.ObjectModel.Uwp.idl
Show resolved
Hide resolved
jwoo-msft
approved these changes
Oct 8, 2021
|
Test issue tracked in #6553 |
beervoley
added a commit
that referenced
this pull request
Nov 19, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [UWP] Input.Text password style support * Fix test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6334
Description
Adds handling of Input.Text password style using Xaml's PasswordBox. Some refactoring to account for the fact that in Xaml a PasswordBox is not the same type as a normal TextBox. Specifically, a new InputValue type is added to support getting values out of a PasswordBox while sharing the validation logic with other styles of Input.Text.
Sample Card
\samples\v.15\Elements\Input.Text.PasswordStyle.json
How Verified
UWP unit tests including new tests to validate password scenarios.
Microsoft Reviewers: Open in CodeFlow