-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported version for teams and appropriate warning message #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licanhua
reviewed
Oct 5, 2021
source/nodejs/adaptivecards-designer/src/containers/teams/teams-container.ts
Show resolved
Hide resolved
almedina-ms
reviewed
Oct 5, 2021
almedina-ms
reviewed
Oct 5, 2021
licanhua
approved these changes
Oct 6, 2021
almedina-ms
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…icrosoft#6509) * Changed teams target version to 1.4 * Changed warning message to highlight 1.4 support in teams only for bot sent card * fixed warning to only display if the target version in designer is v1.4 * Removed extra line and swithced tabs to spaces * Converted tabs to spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #6314.
The designer is now updated to show an appropriate warning with teams containers to indicate support only for bot sent cards.
Microsoft Reviewers: Open in CodeFlow