Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported version for teams and appropriate warning message #6509

Merged
merged 8 commits into from
Oct 7, 2021

Conversation

JeanRoca
Copy link
Contributor

@JeanRoca JeanRoca commented Oct 5, 2021

This addresses #6314.

The designer is now updated to show an appropriate warning with teams containers to indicate support only for bot sent cards.

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Oct 5, 2021

Hi @JeanRoca. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

Copy link
Contributor

@almedina-ms almedina-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@licanhua licanhua merged commit bb14fe7 into microsoft:main Oct 7, 2021
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
…icrosoft#6509)

* Changed teams target version to 1.4

* Changed warning message to highlight 1.4 support in teams only for bot sent card

* fixed warning to only display if the target version in designer is v1.4

* Removed extra line and swithced tabs to spaces

* Converted tabs to spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants