[Android] Fix behaviour for Filtered ChoiceSet #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo-msft
reviewed
Oct 6, 2021
...roid/adaptivecards/src/main/java/io/adaptivecards/renderer/input/ChoiceSetInputRenderer.java
Outdated
Show resolved
Hide resolved
...roid/adaptivecards/src/main/java/io/adaptivecards/renderer/input/ChoiceSetInputRenderer.java
Show resolved
Hide resolved
...roid/adaptivecards/src/main/java/io/adaptivecards/renderer/input/ChoiceSetInputRenderer.java
Outdated
Show resolved
Hide resolved
...roid/adaptivecards/src/main/java/io/adaptivecards/renderer/input/ChoiceSetInputRenderer.java
Show resolved
Hide resolved
jwoo-msft
reviewed
Oct 6, 2021
source/android/uitestapp/src/androidTest/java/io.adaptivecards.uitestapp/UiTests.kt
Show resolved
Hide resolved
RebeccaAnne
reviewed
Oct 7, 2021
...roid/adaptivecards/src/main/java/io/adaptivecards/renderer/input/ChoiceSetInputRenderer.java
Outdated
Show resolved
Hide resolved
|
/azp run android-ci.yml |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RebeccaAnne
approved these changes
Oct 7, 2021
|
/azp run android-ci.yml |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run AdaptiveCards-.NET-PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
….com/microsoft/AdaptiveCards into user/almedina-ms/FiletedChoiceSetFix
….com/microsoft/AdaptiveCards into user/almedina-ms/FiletedChoiceSetFix
|
/azp run AdaptiveCards-iOS-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run android-ci.yml |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run AdaptiveCards-iOS-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run android-ci.yml |
|
Azure Pipelines successfully started running 1 pipeline(s). |
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Fix all scenarios but empty string * Fix break due to long processing time and add tests * Add comment to explain the synchronized block * Fix comments from PR * Add new test case and cleanup test code * Add wait for popup dismiss * Add wait times for failing tests * Another try to fix the test * Add more wait time * Add more time to all elements test * Ignore test until a fix can be found Co-authored-by: RebeccaAnne <rebecch@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Fix all scenarios but empty string * Fix break due to long processing time and add tests * Add comment to explain the synchronized block * Fix comments from PR * Add new test case and cleanup test code * Add wait for popup dismiss * Add wait times for failing tests * Another try to fix the test * Add more wait time * Add more time to all elements test * Ignore test until a fix can be found Co-authored-by: RebeccaAnne <rebecch@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6483
Fixes #6485
Description
Adds a filter to overrride how does the AutocompleteTextView object used finds matches in the list of options.
The filter checks against lower case versions of the string array to find if the provided string is contained in each string.
Due to the high volume of the elements and the processing time required for comparing each string, the filter has to synchronize the filtered list, otherwise this provokes an application crash.
Finally, tests were added to verify the correct functioning by checking against preffixes, suffixes, substring, case ignoring and empty strings
Sample Card
How Verified
Added UI tests to verify the correct behaviour
Microsoft Reviewers: Open in CodeFlow