-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Add hostConfig to adaptivecards-react project #6577
Conversation
This change shouldn't be necessary as the host config is meant to be made available via the React context provider |
I would like to make adaptivecards-react very simple and it's just a wrapper of adaptivecards. For advanced feature, we can provide HOC, subclass or composition. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* add hostConfig to props * update readme * Fix format
In #6145, adaptivecards-react is added, and which implemented HostConfigContext, but user has to implement its own Provider to customize the hostConfig.
In this PR, it allows react to pass hostConfig from props.
hostConfig takes high priority than customized host config Provider if both hostConfig and provider are used.
Fix #6504
Microsoft Reviewers: Open in CodeFlow