Added placeholderColor support for ACRTextView and value submission bug fix #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo-msft
reviewed
Oct 14, 2021
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRTextView.mm
Outdated
Show resolved
Hide resolved
akaashdev
force-pushed
the
textview-placeholder-fix
branch
from
92d6522
to
ad18aa6
Compare
almedina-ms
reviewed
Oct 18, 2021
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/Resources/ACRQuickActionMultilineView.xib
Show resolved
Hide resolved
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…ug fix (microsoft#6590) * added placeholderColor support for textView * renamed property
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
…ug fix (microsoft#6590) * added placeholderColor support for textView * renamed property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
A Pull Request should close a single issue; multiple issues can be closed when the issues are small and related, but that should be an exception not the rule. Please keep Pull Requests small and targeted; large 'code drops' with dozens of files will be closed and asked to split into reviewable pieces. Reviews that need to be large due to dependencies will be
reviewed on a case-by-case basis.
Please use one of the well-known github fixes keywords to reference
the issue fixed with this PR (eg Fixes #). If an issue doesn't yet exist please create one to aid
in issue tracking.
NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.
Description
For all Pull Requests, please describe how the issue was fixed or how the feature was implemented from a summary level. This information will be used to help provide context to the reviewers of the pull request and should be additive to the issue being closed.
ACRTextViewfor customizing theplaceholderTextColorSample Card
How Verified
How you verified the fix, including one or all of the following:
will aid in code reviews or corresponding fixes on other platforms for eg.
Microsoft Reviewers: Open in CodeFlow