Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Designer] Add Berlin config #6612

Merged
merged 19 commits into from
Oct 21, 2021
Merged

[Designer] Add Berlin config #6612

merged 19 commits into from
Oct 21, 2021

Conversation

licanhua
Copy link
Contributor

@licanhua licanhua commented Oct 19, 2021

This change is based on PR #6530
Closes #6433
Closes #6434
Closes #6435
Closes #6436

  1. Add 6 hosts "Berlin | Light | small", "Berlin | Light | Medium", "Berlin | Light | Large", "Berlin | Dark | Small", "Berlin | Dark | Medium", "Berlin | Dark | Large"
  2. The size definition as below, and 40px is reserved as header on top.
small: {
        height: "200px",
        width: "300px",
    },

medium: {
        height: "308px",
        width: "300px",
    },

large: {
        height: "416px",
        width: "300px",
    },
  • Large
    image
    image

  • Medium
    image
    image

  • Small
    image
    image

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Oct 19, 2021

Hi @licanhua. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@jwoo-msft
Copy link
Member


this seems to be wrong, if the card size is reduced, the users will expect to see the compression of AdaptiveCards. But it appears that only the boundary of the card is changed.

Copy link
Member

@jwoo-msft jwoo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card size seems to be wrong, if the card size is reduced, the users will expect to see the compression of AdaptiveCards. But it appears that only the boundary of the card is changed.

@licanhua
Copy link
Contributor Author

Card size seems to be wrong, if the card size is reduced, the users will expect to see the compression of AdaptiveCards. But it appears that only the boundary of the card is changed.

This is the first version. how to stretch or handle the visual out of card boundary will not be addressed by this PR.
Currently I only tell user: please keep your content inside this box

@ghost ghost removed the Needs: Author Feedback label Oct 20, 2021
@ghost ghost removed the Needs: Author Feedback label Oct 21, 2021
Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@licanhua licanhua enabled auto-merge (squash) October 21, 2021 16:47
@licanhua licanhua merged commit 79f8007 into main Oct 21, 2021
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* Adding Berlin test config

* Updated CSS for light theme

* Additional styling

* revert change to adaptivecards-visualizer

* Add large medium small conf

* change order to small, medium, large

* Container styling and updated host config

* format berlin .css

* address comments: format, background color choice, code ...

* Format

Co-authored-by: Somya Sharma <sosharm@microsoft.com>
Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants