Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlightDetails Sample #6615

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Update FlightDetails Sample #6615

merged 3 commits into from
Oct 20, 2021

Conversation

beervoley
Copy link
Contributor

@beervoley beervoley commented Oct 20, 2021

Fixes #6535

  1. Removed non-existent set wrap property from TextRun in both instances where using RichTextBlock.
  2. Removed non-existent set height property from Column.

Result: card renders without any warnings/errors
image

Microsoft Reviewers: Open in CodeFlow

@beervoley beervoley added the Area-Samples Fixes related to our test samples label Oct 20, 2021
@beervoley beervoley added this to In progress in Current Sprint via automation Oct 20, 2021
Current Sprint automation moved this from In progress to Reviewer approved Oct 20, 2021
@paulcam206 paulcam206 removed this from Reviewer approved in Current Sprint Oct 20, 2021
@beervoley beervoley merged commit 07ffee4 into main Oct 20, 2021
@beervoley beervoley deleted the user/vsiliush/issue-6535 branch October 20, 2021 17:13
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Samples Fixes related to our test samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rendering] Warnings on UWP AdaptiveCardVisualizer when loading flightdetails.json
3 participants