stretch background to fill the berlin container and fix margin/padding size problem #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licanhua
changed the title
paulcam206
previously requested changes
Oct 29, 2021
source/nodejs/adaptivecards-designer/src/containers/berlin/berlin-container.ts
Outdated
Show resolved
Hide resolved
source/nodejs/adaptivecards-designer/src/containers/berlin/berlin-container.ts
Outdated
Show resolved
Hide resolved
ghost
added
the
…lin-container.ts Co-authored-by: Paul Campbell <paulcam@microsoft.com>
paulcam206
approved these changes
Nov 3, 2021
jwoo-msft
approved these changes
Nov 3, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…g size problem (microsoft#6640) * allow background stretchable * Fix berlin config * format css * truncate content if overflow * Update source/nodejs/adaptivecards-designer/src/containers/berlin/berlin-container.ts Co-authored-by: Paul Campbell <paulcam@microsoft.com> * change to textContent Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the outer container 4px(1+1 padding, 1+1 border), and inner container width is 300
Fix #6646 [Designer] berlin conf: correct the margin and padding
Fix #6648 [Designer] berlin conf: In preview, truncate the content when overflow
Fix #6620 [Rendering] background is not stretchable
Fix #6647 [Designer] berlin conf: extend the background to header area
Fix #6649 [Designer] berlin conf: Add a dot button to the header area
Fix #6650 [Designer] berlin conf: Round corner for the background
Before :
After:
Microsoft Reviewers: Open in CodeFlow