-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTL Card Level support to UWP Renderer #6661
Conversation
@paulcam206 should I add a unit test for this scenario? |
yes please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good -- just need unit tests 👍
44a767e
to
cef7740
Compare
added some tests :) |
/azp run AdaptiveCards-iOS-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run android-ci.yml |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run android-ci.yml |
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issue
This PR fixes #6506.
Description
Although the documentation states that
RTL
property is supported on card level, in UWP scenario it was not the case.RTL
property was not utilized and I think it was simply overlooked when UWP renderer was introduced.I've added
RTL
property toAdaptiveCard
class and properly used it to assignFlowDirection
to theRoot FrameworkElement
Sample Card
How Verified
Manually.
Microsoft Reviewers: Open in CodeFlow