Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrain the min size for card design area #6734

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Conversation

licanhua
Copy link
Contributor

@licanhua licanhua commented Nov 12, 2021

Fix #6715
set minHeight on acd-previewAndBottomDocks to avoid bottom to up push
set minWidth on acd-designer-cardArea to avoid right to left push

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Nov 12, 2021

Hi @licanhua. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good -- make sure you test at high zoom (see #6320 for more context)

@beervoley
Copy link
Contributor

Thanks @licanhua!!!

@licanhua licanhua merged commit f1b5339 into main Nov 19, 2021
@licanhua licanhua deleted the user/canli/dockerissue branch November 19, 2021 17:37
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Designer] Card preview is not visible when Payload editor window is too large
3 participants