Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pic2card and experimental source #6790

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Nov 29, 2021

Related Issue

Fixes #6789

Description

Simple removal of pic2card and experimental source since it should not live in our codebase.

How Verified

  • local build and test of site
Microsoft Reviewers: Open in CodeFlow

@licanhua
Copy link
Contributor

Can you keep source/pic2card/README.md, and state that that project is deprecated and source code is in https://github.com/microsoft/AdaptiveCards/releases/tag/21.09?

@licanhua
Copy link
Contributor

workflow, bug template and adaptivecards/readme need to update too

image
image

source/pic2card/README.md Show resolved Hide resolved
@ghost
Copy link

ghost commented Dec 5, 2021

Hi @paulcam206. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@almedina-ms
Copy link
Contributor

With the removal of this project and the vs extension which were provided by the community, is there some plan in place to move these tools into a different repository?

@ghost
Copy link

ghost commented Jan 7, 2022

Staleness reset by paulcam206

Fixes #6789

Also remove `experimental` folder...
@paulcam206
Copy link
Member Author

With the removal of this project and the vs extension which were provided by the community, is there some plan in place to move these tools into a different repository?

The VS extension was already shipping out of a different repository, so there's really no action to take. I think we would want to partner with folks to spotlight community work (and be available to provide guidance or support if they'd like), but it's not really appropriate to host external tools here...

@paulcam206 paulcam206 marked this pull request as ready for review January 7, 2022 23:16
@paulcam206 paulcam206 changed the title Remove pic2card source Remove pic2card and experimental source Jan 7, 2022
@paulcam206 paulcam206 merged commit 3e831e5 into main Jan 8, 2022
@paulcam206 paulcam206 deleted the paulcam/remove-pic2card branch January 8, 2022 00:36
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Fixes microsoft#6789

Also remove `experimental` folder...

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Fixes microsoft#6789

Also remove `experimental` folder...

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unneeded pic2card source
5 participants