[iOS] Added error messages in string for Unit Tests #6793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licanhua
approved these changes
Dec 2, 2021
almedina-ms
reviewed
Dec 3, 2021
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizerTests/ADCIOSVisualizerTests.mm
Outdated
Show resolved
Hide resolved
almedina-ms
reviewed
Dec 3, 2021
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACOAdaptiveCard.mm
Outdated
Show resolved
Hide resolved
paulcam206
approved these changes
Dec 3, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [iOS] Error Messages in String for Unit Tests * [ios] fixed typo
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [iOS] Error Messages in String for Unit Tests * [ios] fixed typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #6792
Description
When the unit test is failed while parsing, current tests don't tell which file failed and why. It requires mac & XCode to debug card issues. By adding the file name, and the reason in the string, PR validation failure can be diagnosed by
anyone who raised PR without needing mac & XCode.
NSLog is replaced with printf as NSLog can't output to stderr or stdout, and usage of prinf is recommended.
Reference
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow