Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source form distribution in cocoapods #6795

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

janusbal
Copy link
Contributor

@janusbal janusbal commented Nov 30, 2021

Related Issue

A Pull Request should close a single issue; multiple issues can be closed when the issues are small and related, but that should be an exception not the rule. Please keep Pull Requests small and targeted; large 'code drops' with dozens of files will be closed and asked to split into reviewable pieces. Reviews that need to be large due to dependencies will be
reviewed on a case-by-case basis.

Please use one of the well-known github fixes keywords to reference
the issue fixed with this PR (eg Fixes #). If an issue doesn't yet exist please create one to aid
in issue tracking.

NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.

Description

For all Pull Requests, please describe how the issue was fixed or how the feature was implemented from a summary level. This information will be used to help provide context to the reviewers of the pull request and should be additive to the issue being closed.

Sample Card

If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.

How Verified

How you verified the fix, including one or all of the following:

  1. New unit tests that were added if any. If none were added please add a quick line explaining why not.
  2. Existing relevant unit/regression tests that you ran
  3. Manual scenario verification if any; Do include .gif's or screenshots of the testing you performed here if you think that it
    will aid in code reviews or corresponding fixes on other platforms for eg.
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Nov 30, 2021

CLA assistant check
All CLA requirements met.

AdaptiveCards.podspec Outdated Show resolved Hide resolved
@janusbal janusbal marked this pull request as ready for review November 30, 2021 23:57
@jwoo-msft jwoo-msft enabled auto-merge (squash) December 1, 2021 19:24
Copy link
Contributor

@jonmill jonmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwoo-msft jwoo-msft merged commit 1fe7469 into microsoft:main Dec 1, 2021
jwoo-msft pushed a commit that referenced this pull request Dec 2, 2021
* source form distribution

* changing import style

* adding podspec for testing

* changing platform from ios 12 to 14

* removing unneeded podspec

Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>
jwoo-msft added a commit that referenced this pull request Dec 3, 2021
* [iOS] Updated symlinks on release branch

* Source form distribution in cocoapods (#6795)

* source form distribution

* changing import style

* adding podspec for testing

* changing platform from ios 12 to 14

* removing unneeded podspec

Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>

* [iOS] Updated Project file

Co-authored-by: janusbal <86079148+janusbal@users.noreply.github.com>
Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* source form distribution

* changing import style

* adding podspec for testing

* changing platform from ios 12 to 14

* removing unneeded podspec

Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* source form distribution

* changing import style

* adding podspec for testing

* changing platform from ios 12 to 14

* removing unneeded podspec

Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants