-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source form distribution in cocoapods #6795
Merged
jwoo-msft
merged 5 commits into
microsoft:main
from
janusbal:janus/sourceFormDistribution
Dec 1, 2021
Merged
Source form distribution in cocoapods #6795
jwoo-msft
merged 5 commits into
microsoft:main
from
janusbal:janus/sourceFormDistribution
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janusbal
commented
Nov 30, 2021
jwoo-msft
reviewed
Nov 30, 2021
jwoo-msft
approved these changes
Dec 1, 2021
jonmill
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jwoo-msft
pushed a commit
that referenced
this pull request
Dec 2, 2021
* source form distribution * changing import style * adding podspec for testing * changing platform from ios 12 to 14 * removing unneeded podspec Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>
jwoo-msft
added a commit
that referenced
this pull request
Dec 3, 2021
* [iOS] Updated symlinks on release branch * Source form distribution in cocoapods (#6795) * source form distribution * changing import style * adding podspec for testing * changing platform from ios 12 to 14 * removing unneeded podspec Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com> * [iOS] Updated Project file Co-authored-by: janusbal <86079148+janusbal@users.noreply.github.com> Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* source form distribution * changing import style * adding podspec for testing * changing platform from ios 12 to 14 * removing unneeded podspec Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* source form distribution * changing import style * adding podspec for testing * changing platform from ios 12 to 14 * removing unneeded podspec Co-authored-by: Janus Balatbat <jsbalatbat@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
A Pull Request should close a single issue; multiple issues can be closed when the issues are small and related, but that should be an exception not the rule. Please keep Pull Requests small and targeted; large 'code drops' with dozens of files will be closed and asked to split into reviewable pieces. Reviews that need to be large due to dependencies will be
reviewed on a case-by-case basis.
Please use one of the well-known github fixes keywords to reference
the issue fixed with this PR (eg Fixes #). If an issue doesn't yet exist please create one to aid
in issue tracking.
NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.
Description
For all Pull Requests, please describe how the issue was fixed or how the feature was implemented from a summary level. This information will be used to help provide context to the reviewers of the pull request and should be additive to the issue being closed.
Sample Card
If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.
How Verified
How you verified the fix, including one or all of the following:
will aid in code reviews or corresponding fixes on other platforms for eg.
Microsoft Reviewers: Open in CodeFlow