Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Fix #6810: onAnchorClicked() should pass the anchor element itself #6837

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

robin-liao
Copy link
Contributor

@robin-liao robin-liao commented Dec 9, 2021

Related Issue

#6810

Description

See #6810 for details

Sample Card

{
  "$schema": "https://adaptivecards.io/schemas/adaptive-card.json",
  "type": "AdaptiveCard",
  "version": "1.0",
  "body": [
    {
      "type": "TextBlock",
      "text": "[**hyperlink strong**](https://microsoft.com)"
    }
  ]
}

How Verified

How you verified the fix, including one or all of the following:

  1. Register onAnchorClicked() callback to SDK
  2. Send a card as above
  3. Expect onAnchorClicked() with target of <a> tag with href rather than <strong> tag
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Dec 9, 2021

Hi @robin-liao. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@robin-liao robin-liao marked this pull request as draft December 9, 2021 22:31
@robin-liao robin-liao marked this pull request as ready for review December 9, 2021 22:32
@paulcam206 paulcam206 merged commit c05dca8 into microsoft:main Dec 9, 2021
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants