Rounding off to 2 decimals for constraint multiplier for Image Renderer

[shabripabba]

Related Issue

Fixed #6846
Teams application when using a subclass of ACRImageRenderer as a CustomImageRenderer, crashes on some magic ratio number, when a card of a certain payload is expanded.

Description

Issue is being fixed by making sure that ratio is rounded of to 2 decimals, keeping the image as accurate as it can be, and avoiding a magic ratio number on which apple has some crash

Sample Card

{
"type": "AdaptiveCard",
"version": "1.0",
"body": [
{
"height": "auto",
"type": "Image",
"url": "https://picsum.photos/744/84",
"altText": "Power Automate approvals logo"
},
{
"size": "large",
"weight": "bolder",
"type": "TextBlock",
"text": "Review new SharePoint file 'AppInstallViewData.json'"
},
{
"type": "TextBlock",
"text": "Requested by Sagar Pant Pant.Sagar@microsoft.com",
"wrap": true
},
{
"facts": [
{
"title": "Date Created",
"value": "{{DATE(2021-11-26T11:50:05Z, LONG)}} {{TIME(2021-11-26T11:50:05Z)}}"
},
{
"title": "Link",
"value": "AppInstallViewData.json"
}
],
"type": "FactSet"
},
{
"wrap": true,
"id": "ApprovalDetailsSection",
"type": "TextBlock",
"text": "- Added to: Shared Documents/\n- Created by: Sagar Pant Pant.Sagar@microsoft.com\n- Created time (UTC): 2021-11-26T11:49:29Z"
},
{
"actions": [
{
"title": "Approve",
"card": {
"body": [
{
"type": "TextBlock",
"text": "Comments",
"wrap": true
},
{
"id": "comments1",
"placeholder": "Enter comments",
"type": "Input.Text",
"isMultiline": true,
"maxLength": 2048
}
],
"type": "AdaptiveCard",
"actions": [
{
"title": "Submit",
"data": {
"OnBehalfOfNotice": "Requested by Sagar Pant Pant.Sagar@microsoft.com",
"ApprovalName": "53243a00-68e8-42c0-87bd-5964e9d322c9",
"SelectedOption": "Approve",
"Options": [
"Approve",
"Reject"
],
"MessageTitle": "Review new SharePoint file 'AppInstallViewData.json'",
"ApprovalTitle": "Review new SharePoint file 'AppInstallViewData.json'",
"ApprovalLink": "https://flow.microsoft.com/manage/environments/839eace6-59ab-4243-97ec-a5b8fcc104e4/approvals/received/53243a00-68e8-42c0-87bd-5964e9d322c9?loginTenant=72f988bf-86f1-41af-91ab-2d7cd011db47",
"ItemLinkDescription": "AppInstallViewData.json",
"Details": "- Added to: Shared Documents/\n- Created by: Sagar Pant Pant.Sagar@microsoft.com\n- Created time (UTC): 2021-11-26T11:49:29Z",
"Environment": "839eace6-59ab-4243-97ec-a5b8fcc104e4",
"CreatorName": "Sagar Pant",
"CreationTime": ""Friday, 26 November 2021 11:50 GMT"",
"ActionType": 1,
"CreatorEmail": "Pant.Sagar@microsoft.com",
"ItemLink": "https://microsoftapc.sharepoint.com/teams/Testteam2182/Shared%20Documents/AppInstallViewData.json"
},
"type": "Action.Submit"
}
],
"version": "1.0"
},
"type": "Action.ShowCard"
},
{
"title": "Reject",
"card": {
"body": [
{
"type": "TextBlock",
"text": "Comments",
"wrap": true
},
{
"id": "comments2",
"placeholder": "Enter comments",
"type": "Input.Text",
"isMultiline": true,
"maxLength": 2048
}
],
"type": "AdaptiveCard",
"actions": [
{
"title": "Submit",
"data": {
"OnBehalfOfNotice": "Requested by Sagar Pant Pant.Sagar@microsoft.com",
"ApprovalName": "53243a00-68e8-42c0-87bd-5964e9d322c9",
"SelectedOption": "Reject",
"Options": [
"Approve",
"Reject"
],
"MessageTitle": "Review new SharePoint file 'AppInstallViewData.json'",
"ApprovalTitle": "Review new SharePoint file 'AppInstallViewData.json'",
"ApprovalLink": "https://flow.microsoft.com/manage/environments/839eace6-59ab-4243-97ec-a5b8fcc104e4/approvals/received/53243a00-68e8-42c0-87bd-5964e9d322c9?loginTenant=72f988bf-86f1-41af-91ab-2d7cd011db47",
"ItemLinkDescription": "AppInstallViewData.json",
"Details": "- Added to: Shared Documents/\n- Created by: Sagar Pant Pant.Sagar@microsoft.com\n- Created time (UTC): 2021-11-26T11:49:29Z",
"Environment": "839eace6-59ab-4243-97ec-a5b8fcc104e4",
"CreatorName": "Sagar Pant",
"CreationTime": ""Friday, 26 November 2021 11:50 GMT"",
"ActionType": 1,
"CreatorEmail": "Pant.Sagar@microsoft.com",
"ItemLink": "https://microsoftapc.sharepoint.com/teams/Testteam2182/Shared%20Documents/AppInstallViewData.json"
},
"type": "Action.Submit"
}
],
"version": "1.0"
},
"type": "Action.ShowCard"
}
],
"type": "ActionSet"
}
]
}

How Verified

Verified the fix using manual testing

1. tested whether the test app is still running and the above card is displayed properly and that "Approve" button works on the test app.
2. Verified this change and added it manually in client (teams) app to check if the crash would be fixed.

Microsoft Reviewers: Open in CodeFlow