Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package-lock.json and use npm latest #6869

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Conversation

licanhua
Copy link
Contributor

@licanhua licanhua commented Jan 6, 2022

Because of #6639, package-lock.json should be "lockfileVersion": 2
Look like someone is not using the last npm package.
This problem is addressed by clang-format-ci pipeline

Note: git status check is disabled by default in clang-format-launcher 0.1.4, so it will not catch package-lock issue in the future

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jan 6, 2022

Hi @licanhua. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@licanhua licanhua changed the title update package-lock.json update package-lock.json and use npm latest Jan 6, 2022
@licanhua licanhua marked this pull request as ready for review January 6, 2022 19:35
@licanhua licanhua enabled auto-merge (squash) January 7, 2022 23:44
@licanhua licanhua merged commit 494f5ca into main Jan 7, 2022
@licanhua licanhua deleted the canhua/packagejsonlock branch January 7, 2022 23:55
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* update package.json

* udpate npm itself in pipeline

* skip git status check
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* update package.json

* udpate npm itself in pipeline

* skip git status check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants