Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move swiper to peerdependency #6870

Merged
merged 7 commits into from
Jan 11, 2022
Merged

move swiper to peerdependency #6870

merged 7 commits into from
Jan 11, 2022

Conversation

licanhua
Copy link
Contributor

@licanhua licanhua commented Jan 6, 2022

Fix #6746

swiper was in devdependency. it should be in dependency or peerdependency.

peerdependency is chosen because when I listed it as dependency, I hit:

Then I hit this compilation error for adaptivecards-react app:
              Field 'browser' doesn't contain a valid alias configuration
              c:\repo\adaptivecards\source\nodejs\node_modules\swiper.js doesn't exist
        c:\repo\adaptivecards\source\nodejs\node_modules\swiper doesn't exist
      c:\repo\adaptivecards\source\node_modules doesn't exist or is not a directory
      c:\repo\adaptivecards\node_modules doesn't exist or is not a directory
      c:\repo\node_modules doesn't exist or is not a directory
      c:\node_modules doesn't exist or is not a directory
@ ./node_modules/adaptivecards/lib/adaptivecards.js 25:13-34
@ ./src/adaptive-card.tsx 25:33-57
@ ./src/adaptivecards-react.ts 15:13-39

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jan 6, 2022

Hi @licanhua. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@licanhua licanhua marked this pull request as ready for review January 7, 2022 00:33
@licanhua licanhua enabled auto-merge (squash) January 10, 2022 23:04
@licanhua licanhua merged commit f7dfed3 into main Jan 11, 2022
@licanhua licanhua deleted the canhua/peerdependency branch January 11, 2022 04:57
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* move swiper to peerdependency

* update package-lock.json

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JS] react project Cannot find module: 'swiper'. Make sure this package is installed.
4 participants