Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UWP Renderer]: Action/MediaEventInvoker expose a constructor that takes RenderedAdaptiveCard #6911

Merged
merged 11 commits into from
May 3, 2022
Merged

[UWP Renderer]: Action/MediaEventInvoker expose a constructor that takes RenderedAdaptiveCard #6911

merged 11 commits into from
May 3, 2022

Conversation

beervoley
Copy link
Contributor

@beervoley beervoley commented Feb 2, 2022 •
edited

Related Issue

This PR fixes #6681 (in WinRT now).
I've closed WRL PR since UWP Renderer was migrated to WinRT

Description

The following constructors though implemented, were not exposed through .idl for UWP Renderer.
AdaptiveActionInvoker(RenderedAdaptiveCard renderResult)
AdaptiveMediaEventInvoker(RenderedAdaptiveCard renderResult)

I've added these constructors to the .idl so they can be used when Renderer is consumed by a customer.

How Verified

Manually verified by instantiating object in C#.

Microsoft Reviewers: Open in CodeFlow

@beervoley beervoley added Area-Renderers Platform-XAML Bugs or features related to Xaml Renderer labels Feb 2, 2022
@beervoley beervoley changed the title Vsiliush/i 6681 [UWP Renderer]: Action/MediaEventInvoker expose a constructor that takes RenderedAdaptiveCard Feb 2, 2022
@ghost ghost added the no-recent-activity label Feb 8, 2022
@ghost
Copy link

ghost commented Feb 8, 2022

Hi @beervoley. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Feb 16, 2022
@ghost
Copy link

ghost commented Feb 16, 2022

Staleness reset by beervoley

@ghost ghost added the no-recent-activity label Feb 22, 2022
@ghost
Copy link

ghost commented Feb 22, 2022

Hi @beervoley. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Feb 28, 2022
@ghost
Copy link

ghost commented Feb 28, 2022

Staleness reset by beervoley

@ghost ghost added the no-recent-activity label Mar 8, 2022
@ghost
Copy link

ghost commented Mar 8, 2022

Hi @beervoley. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Mar 11, 2022
@ghost
Copy link

ghost commented Mar 11, 2022

Staleness reset by beervoley

@ghost ghost added the no-recent-activity label Mar 21, 2022
@ghost
Copy link

ghost commented Mar 21, 2022

Hi @beervoley. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@jwoo-msft jwoo-msft added this to In progress in Pull Requests Mar 31, 2022
@jwoo-msft jwoo-msft removed this from In progress in Pull Requests Mar 31, 2022
@ghost ghost removed the no-recent-activity label Apr 19, 2022
@ghost
Copy link

ghost commented Apr 19, 2022

Staleness reset by beervoley

@ghost ghost added the no-recent-activity label Apr 25, 2022
@ghost
Copy link

ghost commented Apr 25, 2022

Hi @beervoley. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Apr 27, 2022
@ghost
Copy link

ghost commented Apr 27, 2022

Staleness reset by paulcam206

@ghost ghost added the no-recent-activity label May 3, 2022
@ghost
Copy link

ghost commented May 3, 2022

Hi @beervoley. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@beervoley beervoley merged commit d205de5 into main May 3, 2022
@beervoley beervoley deleted the vsiliush/i_6681 branch May 3, 2022 22:59
@ghost ghost removed the no-recent-activity label May 3, 2022
@ghost
Copy link

ghost commented May 3, 2022

Staleness reset by beervoley

michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@beervoley @michaelfarnsworth
[UWP Renderer]: Action/MediaEventInvoker expose a constructor that ta…
7a37b35 
…kes RenderedAdaptiveCard (microsoft#6911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@licanhua licanhua licanhua left review comments

@jwoo-msft jwoo-msft jwoo-msft approved these changes

@paulcam206 paulcam206 Awaiting requested review from paulcam206

Assignees
No one assigned
Labels
Area-Renderers Platform-XAML Bugs or features related to Xaml Renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UWP] AdaptiveActionInvoker IDL missing non-default ctor
4 participants
@beervoley @jwoo-msft @licanhua @paulcam206