Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site building issue #7098

Merged
merged 4 commits into from
Mar 14, 2022
Merged

Fix site building issue #7098

merged 4 commits into from
Mar 14, 2022

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Mar 7, 2022

Related Issue

N/A

Description

There was a mistake in the build script (the scope was not correct). This commit fixes that.

Sample Card

N/A

How Verified

Building the site works now

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Mar 7, 2022

Hi @PankajBhojwani. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@carlos-zamora carlos-zamora merged commit e950cfe into main Mar 14, 2022
@carlos-zamora carlos-zamora deleted the dev/pabhoj/fix_build branch March 14, 2022 16:41
@JeanRoca JeanRoca mentioned this pull request Apr 5, 2022
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
# Related Issue

N/A

# Description

There was a mistake in the build script (the scope was not correct). This commit fixes that.

# Sample Card

N/A

# How Verified

Building the site works now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants