-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Only enable action buttons when their associated inputs have changed #7104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformat certain things back to how they used to be
ghost
added
the
Needs: Author Feedback
label
Mar 9, 2022
licanhua
reviewed
Mar 10, 2022
licanhua
reviewed
Mar 10, 2022
licanhua
reviewed
Mar 10, 2022
ghost
removed
the
Needs: Author Feedback
label
Mar 10, 2022
licanhua
reviewed
Mar 14, 2022
licanhua
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. I prefer const
over let
in some places, but it's not a blocker for this PR
jwoo-msft
approved these changes
Mar 15, 2022
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…nged (microsoft#7104) * Introduce getAllActions Replace concat with push for perf * Disable actions unless input values change Reformat certain things back to how they used to be * Address review feedback so far * Fix flawed isEnabled behavior * let -> const Co-authored-by: Vsevolod <sevkorobot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Implements #7103
Description
This change adds support for disabling action buttons unless their associated inputs have changed
CardElement.getAllActions
method that makes it easy to retrieve a list of all actions in the cardCardElement.updateActionsEnabledState
that refreshes the visual state of all actions in the cardAction.disabledUnlessAssociatedInputsChange: boolean
property onAction
isEnabled
property is set to false OR if none of its associated inputs have changedSubmitActionBase.updateEnabledState
method that refreshes the visual state of an action button according to the current values of its associated inputsSubmitActionBase.resetReferencedInputsDirtyState
method that allows a host app to indicate that an action's associated inputs are not "dirty" anymore, i.e. their values are current (and the action should therefore be disabled)GlobalSettings.resetInputsDirtyStateAfterActionExecution: boolean
flag that allows a host application to disable the automatic reset of inputs' dirty state after an action button has been clickedSample Card
Initial render:
After the user has updated at least one input:
How verified
Verified manually in adaptivecards-designer-app
Microsoft Reviewers: Open in CodeFlow