-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Add inline YouTube, Vimeo and Dailymotion video playback #7112
Conversation
Add an API to force the release DOM resources
Introduce schema 1.6 and update Media schema
Hi @dclaux. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, but there are a couple of small tweaks to the schema text that we should probably take
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Staleness reset by dclaux |
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Thanks @paulcam206. I have made the changes you suggested. |
Related Issue
Implements #7111
Description
This PR:
Media
element to use an embedded player (hosted in an iFrame) for YouTube, Vimeo and Daily motion videosMedia
element so it attempts to automatically pull a video thumbnail from the appropriate provider to use as a poster, unless theposter
property is setreleaseDOMResources
API that, when called, discards any expensive DOM resource that might have been instantiatedMedia
element implements this method in a meaningful way, namely by disposing of the iFrame that embeds the inline player. After the iFrame has been disposed of, theMedia
element reverts to showing the poster.Media
element source to introduce a new extensibility point, making it possible for host applications to easily add support for additional embedded video players (e.g. Twitch and more)adaptivecards-designer-app
where the various host app CSS files were no longer copied into thedist
folderSample Card
Replace the
url
in the above payload with these additional examples to test Vimeo and Dailymotion:Initial render, with poster pulled from YouTube:
After the play button is clicked:
How Verified
Verified manually in adaptivecards-designer-app
Microsoft Reviewers: Open in CodeFlow