Don't skip over action buttons when in vertical alignment #7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @PankajBhojwani. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
PankajBhojwani
changed the title
PankajBhojwani
changed the title
ghost
added
the
|
Hi @PankajBhojwani. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Staleness reset by PankajBhojwani |
|
Closes #7156 |
carlos-zamora
approved these changes
Mar 31, 2022
jwoo-msft
approved these changes
Mar 31, 2022
paulcam206
approved these changes
Apr 5, 2022
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…7158) * only set to not focusable in horizontal alignment * attempt * only do horizontal alignment fix Co-authored-by: Vsevolod <sevkorobot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7156
When we activate
ShowCard, we want the next item in focus order to be the content that was just newly presented, but we only want this behaviour when the action buttons are horizontally aligned. Because in vertical alignment, we get strange behaviour where it looks like action buttons are being skipped over.This commit makes it so after activating a ShowCard action, we only skip over any remaining action buttons if the actions buttons are horizontally aligned aligned.
Microsoft Reviewers: Open in CodeFlow