Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS] Change cursor to pointer when hover on action #7175

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

anna-dingler
Copy link
Contributor

@anna-dingler anna-dingler commented Mar 30, 2022

Related Issue

Fixes #7161

Description

Issue was fixed by indicating in SCSS that the cursor should be a pointer when hovering over an action.

How Verified

Verified manually in the AdaptiveCards UI Test App.

Before:

Issue.7161.-.Before.mp4

After:

Issue.7161.-.After.mp4
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Mar 30, 2022

Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@anna-dingler anna-dingler marked this pull request as ready for review March 30, 2022 19:04
Copy link
Member

@jwoo-msft jwoo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except those spacing issues

@jwoo-msft jwoo-msft added this to In progress in Pull Requests Mar 31, 2022
@jwoo-msft jwoo-msft removed this from In progress in Pull Requests Mar 31, 2022
@anna-dingler anna-dingler merged commit f65dafd into microsoft:main Apr 4, 2022
@anna-dingler anna-dingler deleted the fixCursor branch April 4, 2022 18:52
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* Change cursor to pointer when hover on action

* Move cursor change out of hover state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rendering] Actions do not display correct mouse pointer unless specified by host application in CSS.
5 participants