Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Updated Sample App #7503

Merged
merged 6 commits into from
Jun 11, 2022
Merged

[iOS] Updated Sample App #7503

merged 6 commits into from
Jun 11, 2022

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Jun 10, 2022 •
edited

Related Issue

Fixed #7502, Fixed #7022, Fixed #7017, Fixed #7018, Fixed #7108

Description

  • These changes remove file path to elements, tests, v1.0, and v.1.1 when the build is built for Release since many of these cards do not have accessibility features built-in.
  • When built for debugging, those cards will be available for visual tests.

Sample Card

N/A

How Verified

Ran VO on iOS devices and manually verified the issues.

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft enabled auto-merge (squash) June 10, 2022 23:10
@jwoo-msft jwoo-msft merged commit 9689d4b into main Jun 11, 2022
@jwoo-msft jwoo-msft deleted the jwoo/ios-updated-app branch June 11, 2022 00:19
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@jwoo-msft @licanhua @michaelfarnsworth
[iOS] Updated Sample App (microsoft#7503)
d402b3d 
* [iOS] Updated Sample App

* updated clang format

Co-authored-by: Canhua Li <licanhua@live.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@jwoo-msft @licanhua
[iOS] Updated Sample App (microsoft#7503)
126b33c 
* [iOS] Updated Sample App

* updated clang format

Co-authored-by: Canhua Li <licanhua@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@licanhua licanhua licanhua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jwoo-msft @licanhua