-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Designer] Add right to left support to designer #7579
Conversation
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. does it cover all?
…o anna/rtlSupport
…o anna/rtlSupport
It covers the element that show rtl support in the schema ( |
Description
We needed to add
rtl
support to the designer for the following elements:AdaptiveCard
,Container
,Column
, andTableCell
.The cards already supported
rtl
, but we needed a way to enable/disable the feature from theElement Properties
pane.Sample Card
You can now enable/disable
rtl
within the designer for the expected properties as shown below:How Verified
Verified manually in the designer.
Microsoft Reviewers: Open in CodeFlow