-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Designer] Remove focus from card elements #7580
Merged
anna-dingler
merged 7 commits into
microsoft:main
from
anna-dingler:removeFocusFromCardElements
Jul 6, 2022
Merged
[Designer] Remove focus from card elements #7580
anna-dingler
merged 7 commits into
microsoft:main
from
anna-dingler:removeFocusFromCardElements
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into removeFocusFromCardElements
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
anna-dingler
requested review from
almedina-ms,
beervoley,
carlos-zamora,
jwoo-msft,
licanhua and
paulcam206
June 28, 2022 22:10
jwoo-msft
reviewed
Jun 28, 2022
paulcam206
reviewed
Jun 29, 2022
KesemZ
approved these changes
Jul 6, 2022
beervoley
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Remove focus from elements in design mode * Remove extra tabIndex assignment * Add isDesignMode() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Progress towards #7436
Description
Focus should land on designer peers instead of the card elements themselves.
We need to set
tabIndex= -1
based on whether or not the user is in design mode. The change was made for elements that still need access to focus when in preview mode (input elements and actions).Sample Card
How Verified
Verified manually on the adaptivecards site.
Microsoft Reviewers: Open in CodeFlow