[Designer] Add host parameter json editor to designer #7702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
anna-dingler
commented
Jul 20, 2022
anna-dingler
commented
Jul 20, 2022
anna-dingler
commented
Jul 20, 2022
anna-dingler
requested review from
paulcam206,
licanhua,
almedina-ms,
beervoley,
jwoo-msft and
KesemZ
licanhua
reviewed
Jul 21, 2022
licanhua
reviewed
Jul 21, 2022
paulcam206
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
looks good once you address @licanhua's comments... I can help dig in a bit more on investigating some of the questions you have :)
…aptiveCards into anna/hostParameters
licanhua
reviewed
Jul 25, 2022
licanhua
reviewed
Jul 25, 2022
licanhua
approved these changes
Jul 25, 2022
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Add host parameter json editor to designer * Resolve PR comments * Fix formatting * Update comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a JSON editor to the designer so that we can design cards that utilize host parameters.
Sample Card
An example card can be found at: source/nodejs/tests/unit-tests/template-test-resources/complex-template-host.json
How Verified
Verified manually on the AdaptiveCards site
Microsoft Reviewers: Open in CodeFlow