Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handling of Actions for designer peer ordering #7704

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

anna-dingler
Copy link
Contributor

@anna-dingler anna-dingler commented Jul 21, 2022

Related Issue

Fixes #7705

Description

Designer peers were not being added in the correct location when selecting ShowCard actions.

How Verified

Verified manually on the adaptive cards site
ShowCard-1

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jul 21, 2022

Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@anna-dingler anna-dingler marked this pull request as ready for review July 22, 2022 17:54
Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anna-dingler anna-dingler merged commit 6f0cabe into main Jul 26, 2022
@anna-dingler anna-dingler deleted the anna/accessibility branch July 26, 2022 17:12
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* Update handling of Actions for designer peer ordering

* Update source/nodejs/adaptivecards-designer/src/card-designer-surface.ts

Co-authored-by: Paul Campbell <paulcam@microsoft.com>

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Designer Accessibility] ActionSet Peer Ordering
2 participants