Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] [Bug] Set Default language to Fact in FactSet Element #7742

Conversation

karthikgopal36
Copy link
Contributor

@karthikgopal36 karthikgopal36 commented Aug 4, 2022

Description

Month in date is not properly rendering in FactSet. We should explicitly set language if the language is not specified in the Fact element to render the month name properly.

This is work fine SDK sample app. However, this is failing if we test from Client app such as Teams

Sample Card

{
        "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
        "type": "AdaptiveCard",
        "version": "1.2",
        "msTeams": {
          "width": "Full"
        },
        "body": [
          {              
            "type": "TextBlock",
            "size": "Medium",
            "weight": "Bolder",
            "text": "Lorem ipsum"
          },
          { 
            "type": "TextBlock",
            "text": "Lorem ipsum",
            "wrap": true
          }              
        ],
        "actions": [{
        "type": "Action.ShowCard",
        "title": "Details",
        "card": {
          "type": "AdaptiveCard",
          "body": [{
            "type": "FactSet",
            "facts": [
              {
                "title": "Fact1:",
                "value": "Fact1"
              },
              {
                "title": "Fact2:",
                "value": "{{DATE(2017-02-14T06:00:00Z, SHORT)}}"
              }
            ]
          }]
        }
      }]
}

How Verified

before after
Screen Shot 2022-08-04 at 1 17 03 PM Screen Shot 2022-08-04 at 1 18 46 PM
Microsoft Reviewers: Open in CodeFlow

@almedina-ms almedina-ms enabled auto-merge (squash) August 5, 2022 18:57
@almedina-ms almedina-ms merged commit 8dafedd into microsoft:main Aug 5, 2022
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants