Carousel Additional Features #7751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licanhua
reviewed
Aug 9, 2022
5 tasks
licanhua
reviewed
Aug 11, 2022
licanhua
reviewed
Aug 11, 2022
licanhua
approved these changes
Aug 22, 2022
|
/azp run AdaptiveCards-NodeJS-Daily |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
merged without android pr passing since it's a change to spec. |
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* updated * updated carousel spec * updated spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opened for design discussion of #7529
Although it's added on top Carousel spec, it's not going to be added to the spec as written; only the final version that's written as spec will be added.
Current State of Discussion
Deciding between option 2b and 3 on header.
Option 2 is strongly considered for spacing.