[Designer] Update designer service worker #7757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
…o anna/updateDesignerPWA
anna-dingler
changed the title
…o anna/updateDesignerPWA
…/AdaptiveCards into anna/updateDesignerPWA
anna-dingler
commented
Aug 11, 2022
ghost
added
the
|
Hi @anna-dingler. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Staleness reset by anna-dingler |
licanhua
reviewed
Aug 17, 2022
paulcam206
approved these changes
Aug 22, 2022
licanhua
approved these changes
Aug 23, 2022
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Designer: skip waiting when installing service worker * Update caching strategy * Remove designer/ from the precache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a new service worker is installed, we need to make sure that it claims all existing clients on activation and does not wait to take over for the prior service worker.
Otherwise, the new service worker would not take over until prior clients are closed/refreshed.
See documentation here:
https://developer.mozilla.org/en-US/docs/Web/API/Clients/claim
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/skipWaiting
The caching strategy was also changed from StaleWhileRevalidate to NetworkFirst.
How Verified
Tested on the Adaptive Cards Designer.
Microsoft Reviewers: Open in CodeFlow