Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable data binding for the designer #7774

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

anna-dingler
Copy link
Contributor

@anna-dingler anna-dingler commented Aug 24, 2022

Related Issue

Fixes #6631

Description

Updated setValue and serialization methods so that values are not deleted from the propertyBag if GlobalSettings.enableFullJsonRoundTrip === true.

Note: Data binding will only work while in preview mode.

Sample Card

{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5",
    "body": [
        {
            "type": "TextBlock",
            "text": "Image test:",
            "wrap": true
        },
        {
            "type": "Image",
            "url": "https://pbs.twimg.com/profile_images/3647943215/d7f12830b3c17a5a9e4afcc370e3a37e_400x400.jpeg",
            "width": "${imageSize}",
            "height": "${imageSize}"
        }
    ]
}

Data JSON

{
    "imageSize": "100px"
}

How Verified

Verified manually on the AdaptiveCards site

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Aug 24, 2022

Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@anna-dingler anna-dingler marked this pull request as ready for review August 24, 2022 19:19
@anna-dingler anna-dingler merged commit 467bcb7 into main Aug 24, 2022
@anna-dingler anna-dingler deleted the anna/designerDataBinding branch August 24, 2022 23:44
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* Enable data binding for the designer

* Remove changes to setValue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] support template bool for rtl and other boolean properties.
3 participants