Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated css #7806

Merged
merged 4 commits into from
Sep 2, 2022
Merged

updated css #7806

merged 4 commits into from
Sep 2, 2022

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Aug 31, 2022

Related Issue

Fixed #7659

Description

Carousel paginations become blended to background in high contrast mode.
This change addresses the issue by using @media and removing the high contrast changes and sets appropriate background color for pagination.

How Verified

Manually verified as below.

Before Fix

Berlin dark
Screenshot 2022-08-31 145910-dark

Berlin light
Screenshot 2022-08-31 145938-light

After Fix

Screenshot 2022-08-31 145303

Screenshot 2022-08-31 145327

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Aug 31, 2022

Hi @jwoo-msft. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@ghost ghost removed the Needs: Author Feedback label Sep 2, 2022
@jwoo-msft jwoo-msft enabled auto-merge (squash) September 2, 2022 00:41
@jwoo-msft jwoo-msft merged commit a01a211 into main Sep 2, 2022
@jwoo-msft jwoo-msft deleted the jwoo/js-high-contrast-fix branch September 2, 2022 19:39
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* updated css

* system font

* flashed it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Carousel A11y] Buttons are not visible in high-contrast
3 participants