Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntax highlighting in Monaco diff editor #263

Merged
merged 14 commits into from
Jul 2, 2024
Merged

Add syntax highlighting in Monaco diff editor #263

merged 14 commits into from
Jul 2, 2024

Conversation

getkeshav
Copy link
Collaborator

@getkeshav getkeshav commented Jun 13, 2024 •
edited
Loading

Updates:

  1. Added syntax highlighting for TMDL in Monaco diff editor.
  2. Updated the version of monaco-editor from 0.12.0 to 0.15.6 because our current implementation of token provider doesn't support in older version.

Testing

image

Anything else I should now?

Multiline strings not enclosed in triple backticks are not highlighted correctly. Handling this case is not feasible with the Monarch token provider.

@getkeshav getkeshav marked this pull request as ready for review June 20, 2024 06:15
@hritik7080 hritik7080 self-assigned this Jun 21, 2024
@hritik7080 hritik7080 requested a review from svemuri8 June 27, 2024 04:44
Keshav Kumar (MAQ LLC) added 2 commits June 27, 2024 16:44
@svemuri8 svemuri8 merged commit 9440ef0 into master Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svemuri8 svemuri8 svemuri8 approved these changes

@christianwade christianwade Awaiting requested review from christianwade

Assignees

@hritik7080 hritik7080

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@getkeshav @svemuri8 @hritik7080