Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #1002

Merged
merged 7 commits into from Nov 3, 2020
Merged

Update CODEOWNERS #1002

merged 7 commits into from Nov 3, 2020

Conversation

MichelleSwafford
Copy link
Contributor

Updating CODEOWNER with Staged Rollout contacts

PR Checklist

  • Explain your changes, so people looking at the PR know what and why, the code changes are the how.
  • if updating templates, it is helpful to post a screenshot of what the changes look like.
  • if updating templates, ensure that your parameters and steps have meaningful names.
  • if adding new templates, ensure that your parameters and columns have display names.
  • if adding new templates, or changing items in a gallery, it's helpful to post a screenshot of what the gallery looks like now

Updating CODEOWNER with Staged Rollout contacts
@MichelleSwafford MichelleSwafford requested a review from a team as a code owner October 27, 2020 22:55
Copy link
Contributor

@gardnerjr gardnerjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didn't need to make a new PR for this, you could have added this to your existing PR. as is right now, this would block your other PR since you'd be the only person allowed to approve but you can't approve your own changes

CODEOWNERS Outdated Show resolved Hide resolved
@MichelleSwafford
Copy link
Contributor Author

Are there any additional changes required before this can be approved?

@MichelleSwafford
Copy link
Contributor Author

Can this be checked-in?

@MichelleSwafford MichelleSwafford dismissed gardnerjr’s stale review October 30, 2020 17:29

Added azure-ad-workbooks as reviewers

@MichelleSwafford
Copy link
Contributor Author

#sign-off

@gardnerjr gardnerjr mentioned this pull request Nov 3, 2020
5 tasks
@danielwood95
Copy link
Contributor

Michelle is a member of @azure-ad-worbooks so she doesn't need to be individually added to CODEOWNERS.

@gardnerjr gardnerjr reopened this Nov 3, 2020
@gardnerjr
Copy link
Contributor

you closed it, but the PR here didn't add JUST michelle, it added codeowners entirely. so like i said in the other PR, unless THAT PR updates codeowners (it doesn't!), then this PR needs to be completed. One of the 2 PR's has to update CODEOWNERS so the new template has code owners set up right from the start. if she doesn't explicitly need to be on the list, then the PR should be edited to remove her but leave the team ownership.

@MichelleSwafford MichelleSwafford merged commit d392821 into master Nov 3, 2020
@gardnerjr gardnerjr deleted the MichelleSwafford-patch-3 branch May 27, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants