New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS #1002
Update CODEOWNERS #1002
Conversation
Updating CODEOWNER with Staged Rollout contacts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you didn't need to make a new PR for this, you could have added this to your existing PR. as is right now, this would block your other PR since you'd be the only person allowed to approve but you can't approve your own changes
Are there any additional changes required before this can be approved? |
Can this be checked-in? |
Added azure-ad-workbooks as reviewers
#sign-off |
Michelle is a member of @azure-ad-worbooks so she doesn't need to be individually added to CODEOWNERS. |
you closed it, but the PR here didn't add JUST michelle, it added codeowners entirely. so like i said in the other PR, unless THAT PR updates codeowners (it doesn't!), then this PR needs to be completed. One of the 2 PR's has to update CODEOWNERS so the new template has code owners set up right from the start. if she doesn't explicitly need to be on the list, then the PR should be edited to remove her but leave the team ownership. |
Updating CODEOWNER with Staged Rollout contacts
PR Checklist