Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AtResource Workbook for ServiceBus to start implementing Portal changes #1447

Merged

Conversation

ppgovekar
Copy link
Contributor

@ppgovekar ppgovekar commented May 10, 2021

Add AtResource Workbook for ServiceBus to start implementing Portal changes

Adding AtResource Workbook for ServiceBus which is shared by Ashish for getting started with Portal changes to replace Metric ResourceMenu with Workbook and Insights.

Screenshot of how Workbook will look in the Portal:
image
image
image

If adding or updating templates:

  • post a screenshot of templates and/or gallery changes
  • ensure your template has a corresponding gallery entry in the gallery folder
  • If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
  • ensure all steps have meaningful names
  • ensure all parameters and grid columns have display names set so they can be localized
  • ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
  • ensure that steps names are unique or they will fail PR validation (step names are used for localization)
  • grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
  • remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

@ppgovekar ppgovekar requested a review from a team as a code owner May 10, 2021 17:32
@yves-chan
Copy link
Contributor

@ppgovekar I gave it another review, just some minor cocmments and I think it's good to go!

@yves-chan
Copy link
Contributor

@ppgovekar, approved, feel free to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants