New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AtResource Workbook for ServiceBus to start implementing Portal changes #1447
Merged
ppgovekar
merged 6 commits into
microsoft:master
from
ppgovekar:ServiceBus-AI-WBK-AtResource0507
May 10, 2021
Merged
Add AtResource Workbook for ServiceBus to start implementing Portal changes #1447
ppgovekar
merged 6 commits into
microsoft:master
from
ppgovekar:ServiceBus-AI-WBK-AtResource0507
May 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yves-chan
reviewed
May 10, 2021
yves-chan
reviewed
May 10, 2021
@ppgovekar I gave it another review, just some minor cocmments and I think it's good to go! |
yves-chan
approved these changes
May 10, 2021
@ppgovekar, approved, feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AtResource Workbook for ServiceBus to start implementing Portal changes
Adding AtResource Workbook for ServiceBus which is shared by Ashish for getting started with Portal changes to replace Metric ResourceMenu with Workbook and Insights.
Screenshot of how Workbook will look in the Portal:
If adding or updating templates:
/subscription/
and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validationfallbackResourceIds
andfromTemplateId
fields from your template workbook or they will fail PR validation