[BUG] IE8 Support was broken by several components #1823

microsoft · Apr 29, 2022 · 61a9b8e · 61a9b8e
1 parent c8e40ff
commit 61a9b8e
Show file tree

Hide file tree

Showing 26 changed files with 1,345 additions and 1,418 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -5,9 +5,9 @@ name: Node.js CI
 
 on:
   push:
-    branches: [ master ]
+    branches: [ master, Release2.7 ]
   pull_request:
-    branches: [ master ]
+    branches: [ master, Release2.7 ]
 
 jobs:
   build:

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -13,10 +13,10 @@ name: "CodeQL"
 
 on:
   push:
-    branches: [ master ]
+    branches: [ master, Release2.7 ]
   pull_request:
     # The branches below must be a subset of the branches above
-    branches: [ master ]
+    branches: [ master, Release2.7 ]
   schedule:
     - cron: '17 15 * * 2'
 

diff --git a/AISKU/package.json b/AISKU/package.json
@@ -64,7 +64,7 @@
         "tslib": "*"
     },
     "dependencies": {
-        "@microsoft/dynamicproto-js": "^1.1.4",
+        "@microsoft/dynamicproto-js": "^1.1.5",
         "@microsoft/applicationinsights-shims": "2.0.1",
         "@microsoft/applicationinsights-analytics-js": "2.7.4",
         "@microsoft/applicationinsights-channel-js": "2.7.4",

diff --git a/AISKU/src/ApplicationInsightsDeprecated.ts b/AISKU/src/ApplicationInsightsDeprecated.ts
@@ -5,7 +5,7 @@ import {
     IEventTelemetry, IEnvelope, ProcessLegacy
 } from "@microsoft/applicationinsights-common";
 import { Snippet, Initialization as ApplicationInsights } from "./Initialization";
-import { ITelemetryItem, IDiagnosticLogger, IConfiguration, proxyAssign, throwError, ICookieMgr } from "@microsoft/applicationinsights-core-js";
+import { ITelemetryItem, IDiagnosticLogger, IConfiguration, proxyAssign, throwError, ICookieMgr, arrIndexOf } from "@microsoft/applicationinsights-core-js";
 
 // This is an exclude list of properties that should not be updated during initialization
 // They include a combination of private and internal property names
@@ -187,7 +187,7 @@ export class AppInsightsDeprecated implements IAppInsightsDeprecated {
         // Note: This must be called before loadAppInsights is called
         proxyAssign(snippet, this, (name: string) => {
             // Not excluding names prefixed with "_" as we need to proxy some functions like _onError
-            return name && _ignoreUpdateSnippetProperties.indexOf(name) === -1;
+            return name && arrIndexOf(_ignoreUpdateSnippetProperties, name) === -1;
         });
     }
 

diff --git a/AISKU/src/Initialization.ts b/AISKU/src/Initialization.ts
@@ -4,7 +4,7 @@
 import {
     IConfiguration, AppInsightsCore, IAppInsightsCore, LoggingSeverity, _InternalMessageId, ITelemetryItem, ICustomProperties,
     IChannelControls, hasWindow, hasDocument, isReactNative, doPerf, IDiagnosticLogger, INotificationManager, objForEachKey, proxyAssign,
-    arrForEach, isString, isFunction, isNullOrUndefined, isArray, throwError, ICookieMgr, addPageUnloadEventListener,  addPageHideEventListener
+    arrForEach, isString, isFunction, isNullOrUndefined, isArray, throwError, ICookieMgr, addPageUnloadEventListener,  addPageHideEventListener, arrIndexOf
 } from "@microsoft/applicationinsights-core-js";
 import { ApplicationInsights } from "@microsoft/applicationinsights-analytics-js";
 import { Sender } from "@microsoft/applicationinsights-channel-js";
@@ -377,7 +377,7 @@ export class Initialization implements IApplicationInsights {
                     if (isString(field) &&
                             !isFunction(value) &&
                             field && field[0] !== "_" &&                                // Don't copy "internal" values
-                            _ignoreUpdateSnippetProperties.indexOf(field) === -1) {
+                            arrIndexOf(_ignoreUpdateSnippetProperties, field) === -1) {
                         snippet[field as string] = value;
                     }
                 });
@@ -425,7 +425,7 @@ export class Initialization implements IApplicationInsights {
         // Note: This must be called before loadAppInsights is called
         proxyAssign(snippet, this, (name: string) => {
             // Not excluding names prefixed with "_" as we need to proxy some functions like _onError
-            return name && _ignoreUpdateSnippetProperties.indexOf(name) === -1;
+            return name && arrIndexOf(_ignoreUpdateSnippetProperties, name) === -1;
         });
     }
 

diff --git a/AISKULight/package.json b/AISKULight/package.json
@@ -47,7 +47,7 @@
         "tslib": "*"
     },
     "dependencies": {
-        "@microsoft/dynamicproto-js": "^1.1.4",
+        "@microsoft/dynamicproto-js": "^1.1.5",
         "@microsoft/applicationinsights-shims": "2.0.1",
         "@microsoft/applicationinsights-common": "2.7.4",
         "@microsoft/applicationinsights-channel-js": "2.7.4",

diff --git a/channels/applicationinsights-channel-js/package.json b/channels/applicationinsights-channel-js/package.json
@@ -45,7 +45,7 @@
         "tslib": "*"
     },
     "dependencies": {
-        "@microsoft/dynamicproto-js": "^1.1.4",
+        "@microsoft/dynamicproto-js": "^1.1.5",
         "@microsoft/applicationinsights-shims": "2.0.1",
         "@microsoft/applicationinsights-core-js": "2.7.4",
         "@microsoft/applicationinsights-common": "2.7.4"

diff --git a/common/Tests/Framework/package.json b/common/Tests/Framework/package.json
@@ -49,6 +49,6 @@
         "tslib": "*"
     },
     "dependencies": {
-        "@microsoft/dynamicproto-js": "^1.1.4"
+        "@microsoft/dynamicproto-js": "^1.1.5"
     }
 }