add test

add a unit test
microsoft · Mar 6, 2023 · 8d8c617 · 8d8c617
1 parent 68af47f
commit 8d8c617
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 38 deletions.
diff --git a/shared/AppInsightsCommon/Tests/Unit/src/Exception.tests.ts b/shared/AppInsightsCommon/Tests/Unit/src/Exception.tests.ts
@@ -61,43 +61,44 @@ export class ExceptionTests extends AITestClass {
             }
         });
 
-        // this.testCase({
-        //     name: "ExceptionDetails: ExceptionDetails will be truncated",
-        //     test: () => {
-        //         try {
-        //             // const define
-        //             const MAX_MESSAGE_LENGTH = DataSanitizer.MAX_MESSAGE_LENGTH;
-        //             const messageLong = new Array(MAX_MESSAGE_LENGTH + 10).join('abc');
-
-
-        //             let errObj = {
-        //                 reason:{
-        //                     message: "message",
-        //                     stack: messageLong + "\n" + messageLong + "\n" + messageLong
-        //                 }
-        //             };
-
-        //             let exception = Exception.CreateAutoException("message",
-        //                 "url",
-        //                 9,
-        //                 0,
-        //                 errObj
-        //             );
-
-        //             const exceptionDetails = new _ExceptionDetails(this.logger, exception);
-        //             const exceptionDetailsInterface: IExceptionDetailsInternal = exceptionDetails.toInterface();
-
-        //             Assert.ok(exceptionDetailsInterface.stack.length < MAX_MESSAGE_LENGTH)
-        //             // console.log(exceptionDetailsInterface.message)
-        //             // console.log(exceptionDetailsInterface.message.length)
-
-        //         } catch (e) {
-        //             console.log(e.stack);
-        //             console.log(e.toString());
-        //             Assert.ok(false, e.toString());
-        //         }
-        //     }
-        // });
+        this.testCase({
+            name: "ExceptionDetails: ExceptionDetails assembly field will be truncated",
+            test: () => {
+                try {
+                    // const define
+                    const MAX_STRING_LENGTH = DataSanitizer.MAX_STRING_LENGTH;
+                    const messageLong = new Array(MAX_STRING_LENGTH + 10).join("abc");
+
+                    const messageFollowRegex = "at functionName (a.js:1:1)"
+                    const longMessageFollowRegex = messageFollowRegex.replace("functionName", messageLong)
+
+                    let errObj = {
+                        reason:{
+                            message: "message",
+                            stack: longMessageFollowRegex + "\n" + longMessageFollowRegex + "\n" + longMessageFollowRegex
+                        }
+                    };
+
+                    let exception = Exception.CreateAutoException("message",
+                        "url",
+                        9,
+                        0,
+                        errObj
+                    );
+                    const exceptionDetails = new _ExceptionDetails(this.logger, exception);
+                    console.log("exception", exceptionDetails.parsedStack)
+                    console.log(exceptionDetails.parsedStack.length)
+                    for (let i = 0; i < exceptionDetails.parsedStack.length; i++) {
+                        Assert.ok(exceptionDetails.parsedStack[i].assembly.length <= MAX_STRING_LENGTH);
+                        console.log(exceptionDetails.parsedStack[i].assembly.length, MAX_STRING_LENGTH)
+                      }
+                } catch (e) {
+                    console.log(e.stack);
+                    console.log(e.toString());
+                    Assert.ok(false, e.toString());
+                }
+            }
+        });
 
 
         this.testCase({

diff --git a/shared/AppInsightsCommon/src/Telemetry/Exception.ts b/shared/AppInsightsCommon/src/Telemetry/Exception.ts
@@ -535,7 +535,7 @@ export class _ExceptionDetails implements IExceptionDetails, ISerializable {
             _self.parsedStack = _parseStack(stack);
 
             // after parsedStack is inited, iterate over each frame object, sanitize its assembly field
-            if (_self.parsedStack instanceof Array){
+            if (isArray(_self.parsedStack)){
                 arrMap(_self.parsedStack, (frame: _StackFrame) => frame.assembly = dataSanitizeString(logger, frame.assembly));
             }