Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Typescript build with 2.4.0 breaks #1173

Closed
StefanSchoof opened this issue Jan 29, 2020 · 5 comments
Closed

[BUG] Typescript build with 2.4.0 breaks #1173

StefanSchoof opened this issue Jan 29, 2020 · 5 comments
Assignees
Labels

Comments

@StefanSchoof
Copy link

Description/Screenshot
https://dev.azure.com/sschoof/espresso/_build/results?buildId=1514&view=logs&j=0a099ed4-e459-5b34-cc15-88dac43c3262&t=51a3d40f-3f24-5548-8c6e-04827d8ff082&l=37
Steps to Reproduce
Upgrade working Typescript build from 2.3.1 to 2.4.0

  • OS/Browser: n/a
  • SDK Version [e.g. 22]: n/a
  • How you initialized the SDK: n/a

Expected behavior
A version upgrade from 2.3 to 2.4 is not breaking

Additional context
Add any other context about the problem here.

@MSNev MSNev self-assigned this Jan 29, 2020
@MSNev
Copy link
Collaborator

MSNev commented Jan 29, 2020

This appears to be the side effect of a tighter restriction on the arguments from TS 3.7.3 being used as it compiles fine with TS 2.5.3..

Issue summary: There is a difference between the declaration of the function and the actual implementation in the constructor.

I believe I understand the issue and will work on it in the morning.

@MSNev
Copy link
Collaborator

MSNev commented Jan 30, 2020

@StefanSchoof can you confirm how are you consuming the module, while I've manually reviewed the method signatures and published a PR that will address the error, I was unable to reproduce the issue using multiple versions of TypeScript (including 3.7.3). From the error it appears that you are or maybe consuming and re-building/compiling the generated module which is causing the break as it validates against the *.d.ts? Can you confirm?

Either way, is it possible for you to assist by revalidating using this branch (MSNev/TypoFixesForTS3.7 instead of master) and using the generated code at all, this would be extremely helpful so we don't publish 2.4.1 (which we are planning to do tomorrow) and then find yet another blocking issue for you?

@MSNev
Copy link
Collaborator

MSNev commented Jan 30, 2020

Fixed with v2.4.1

@MSNev MSNev closed this as completed Jan 30, 2020
@StefanSchoof
Copy link
Author

Sorry, missed your questions. Too bad I missed a opportunity to help you.

Your fix wokred and with 2.4.1 my build is up again. Thanks for the quick fix.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants