Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexof is wrongly cased #1374

Closed
ncoder opened this issue Sep 16, 2020 · 4 comments
Closed

indexof is wrongly cased #1374

ncoder opened this issue Sep 16, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@ncoder
Copy link

ncoder commented Sep 16, 2020

It should be "indexOf"

I get a "TypeError: r.indexof is not a function" on execution.

if (url.indexof(cdns[idx]) !== -1) {

@MSNev MSNev self-assigned this Sep 16, 2020
@MSNev MSNev added the bug label Sep 16, 2020
MSNev pushed a commit that referenced this issue Sep 16, 2020
MSNev added a commit that referenced this issue Sep 16, 2020
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Sep 16, 2020
@MSNev MSNev added this to the 2.5.9 milestone Sep 30, 2020
@Saibamen
Copy link

Saibamen commented Oct 8, 2020

Can be closed - already released: https://github.com/microsoft/ApplicationInsights-JS/releases/tag/2.5.9

BTW @ncoder: You can easily edit single file in GitHub without even downloading source code :)

Just go to file you mendtioned

if (url.indexof(cdns[idx]) !== -1) {
and click Edit icon. If edit icon is disables, make sure, you have selected master branch. Then you make your changes, creates a commit and then a Pull Request from your browser.

image

@Saibamen
Copy link

Saibamen commented Oct 8, 2020

@MSNev
Copy link
Collaborator

MSNev commented Oct 12, 2020

Closing as 2.5.9 is now completely deployed to NPM and all CDN endpoints

@MSNev MSNev closed this as completed Oct 12, 2020
@MSNev MSNev removed the fixed - waiting release PR Committed and waiting deployment label Oct 12, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants