Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] NPM package for @microsoft/applicationinsights-angularplugin-js does not have a dist folder #1381

Closed
OumarLM opened this issue Sep 17, 2020 · 4 comments
Closed

[BUG] NPM package for @microsoft/applicationinsights-angularplugin-js does not have a dist folder #1381

OumarLM opened this issue Sep 17, 2020 · 4 comments
Assignees
@MSNev
Labels
bug
Milestone
2.5.9

Comments

@OumarLM
Copy link

OumarLM commented Sep 17, 2020

Description/Screenshot
The @microsoft/applicationinsights-angularplugin-js folder in node-modules does not have a dist
folder
Steps to Reproduce
run npm install @microsoft/applicationinsights-angularplugin-js
and check node_modules.

  • OS/Browser:
  • SDK Version [e.g. 22]:
  • How you initialized the SDK:

Expected behavior
not get : Cannot find module '@microsoft/applicationinsights-angularplugin-js' or its corresponding type declarations.
Additional context
Add any other context about the problem here.
@MSNev MSNev changed the title [BUG] [BUG] NPM package for @microsoft/applicationinsights-angularplugin-js does not have a dist folder Sep 17, 2020
@MSNev MSNev added the bug label Sep 17, 2020
@MSNev
Copy link
Collaborator

MSNev commented Sep 17, 2020

Looks like the official build / publish pipeline is not building the angular plugin before packaging -- sorry

@MSNev MSNev self-assigned this Sep 17, 2020
MSNev pushed a commit that referenced this issue Sep 22, 2020
[BUG] NPM package for @microsoft/applicationinsights-angularplugin-js…
5f1e1b4 
… does not have a dist folder #1381
@MSNev MSNev mentioned this issue Sep 22, 2020
Merged
MSNev pushed a commit that referenced this issue Sep 22, 2020
[BUG] NPM package for @microsoft/applicationinsights-angularplugin-js…
49eebfa 
… does not have a dist folder #1381
MSNev pushed a commit that referenced this issue Sep 22, 2020
[BUG] NPM package for @microsoft/applicationinsights-angularplugin-js…
61812c0 
… does not have a dist folder #1381
MSNev pushed a commit that referenced this issue Sep 23, 2020
[BUG] NPM package for @microsoft/applicationinsights-angularplugin-js…
0197faa 
… does not have a dist folder #1381
MSNev pushed a commit that referenced this issue Sep 23, 2020
[BUG] NPM package for @microsoft/applicationinsights-angularplugin-js…
8380474 
… does not have a dist folder #1381
MSNev added a commit that referenced this issue Sep 23, 2020
@MSNev
[BUG] NPM package for @microsoft/applicationinsights-angularplugin-js…
3b46a3a 
… does not have a dist folder #1381 (#1385)
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Sep 23, 2020
@OumarLM
Copy link
Author

OumarLM commented Sep 23, 2020

Awesome!!!

@MSNev MSNev added this to the 2.5.9 milestone Sep 30, 2020
@MSNev
Copy link
Collaborator

MSNev commented Oct 12, 2020 •
edited

Closing as 2.5.9 is now completely deployed to NPM and all CDN endpoints

@MSNev MSNev closed this as completed Oct 12, 2020
@MSNev MSNev removed the fixed - waiting release PR Committed and waiting deployment label Oct 12, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
bug
Projects
None yet
Milestone
2.5.9
Development

No branches or pull requests
2 participants
@MSNev @OumarLM