Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sideEffects field to applicationinsights-shims package.json #1384

Closed
MSNev opened this issue Sep 22, 2020 · 2 comments
Closed

Add sideEffects field to applicationinsights-shims package.json #1384

MSNev opened this issue Sep 22, 2020 · 2 comments
Assignees
@MSNev
Milestone
2.5.9

Comments

@MSNev
Copy link
Collaborator

MSNev commented Sep 22, 2020

To make this package optimizeable via webpack tree shaking, please add a correct sideEffects field to the package.json file for this lib.

thanks to @johncrim for pointing this out as part of an issue raised in microsoft/DynamicProto-JS#22
@MSNev MSNev self-assigned this Sep 22, 2020
MSNev pushed a commit that referenced this issue Sep 23, 2020
Add sideEffects field to applicationinsights-shims package.json #1384
3a54555
MSNev pushed a commit that referenced this issue Sep 23, 2020
Add sideEffects field to applicationinsights-shims package.json #1384
792a5ce
MSNev added a commit that referenced this issue Sep 23, 2020
@MSNev
Add sideEffects field to applicationinsights-shims package.json #1384 (…
dbb481a 
…#1386)
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Sep 23, 2020
MSNev pushed a commit that referenced this issue Sep 24, 2020
Bump shims version for React, React-Native and Angular to latest.
fc0068a 
- Part of Add sideEffects field to applicationinsights-shims package.json #1384
@MSNev MSNev mentioned this issue Sep 24, 2020
Merged
MSNev pushed a commit that referenced this issue Sep 24, 2020
Bump shims version for React, React-Native and Angular to latest.
966d527 
- Part of Add sideEffects field to applicationinsights-shims package.json #1384
MSNev added a commit that referenced this issue Sep 24, 2020
@MSNev
Bump shims version for React, React-Native and Angular to latest. (#1388
3a40f5d 
)

- Part of Add sideEffects field to applicationinsights-shims package.json #1384
@MSNev MSNev added this to the 2.5.9 milestone Sep 30, 2020
@MSNev
Copy link
Collaborator Author

MSNev commented Oct 12, 2020 •
edited

Closing as 2.5.9 is now completely deployed to NPM and all CDN endpoints

@MSNev MSNev closed this as completed Oct 12, 2020
@MSNev MSNev removed the fixed - waiting release PR Committed and waiting deployment label Oct 12, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
None yet
Projects
None yet
Milestone
2.5.9
Development

No branches or pull requests
1 participant
@MSNev