Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Angular project doesn't build after install latest version v.2.8.0 #1807

Closed
cmonzon44 opened this issue Apr 19, 2022 · 14 comments
Closed
Assignees
Labels
released - NPM ts# compat Typescript version compatibility issue
Milestone

Comments

@cmonzon44
Copy link

cmonzon44 commented Apr 19, 2022

Angular project doesn't build after install latest version v.2.8.0

image

ERROR in node_modules/@microsoft/applicationinsights-core-js/types/JavaScriptSDK.Enums/EnumHelperFuncs.d.ts:33:30 - error TS1005: ',' expected.

 [key in keyof E]: [eValue: E[keyof E], mapValue: V[keyof V]];

I should to set version 2.7.4 to build correctly again.

@MSNev
Copy link
Collaborator

MSNev commented Apr 19, 2022

Yes, we will prepare a release which uses 2.8.0

@MSNev MSNev self-assigned this Apr 19, 2022
@javier-caparo
Copy link

Same here for us, using "typescript: ~3.8.3" in our package.json , which calls this dependency: "Microsoft Application Insights JavaScript SDK - Core" ( @microsoft/applicationinsights-core-js , version : 2.8.0)


ERROR in node_modules/@microsoft/applicationinsights-core-js/types/JavaScriptSDK.Enums/EnumHelperFuncs.d.ts:33:30 - error TS1005: ',' expected.

33 [key in keyof E]: [eValue: E[keyof E], mapValue: V[keyof V]];

                       ~

node_modules/@microsoft/applicationinsights-core-js/types/JavaScriptSDK.Enums/EnumHelperFuncs.d.ts:33:52 - error TS1005: ',' expected.

33 [key in keyof E]: [eValue: E[keyof E], mapValue: V[keyof V]];


Workaround:

a) we created the package-lock.json and then modifying the dependency version of @microsoft/applicationinsights-core-js to 2.5.10.

and then execute
b) npm ci

c) npm build

it works!!

@MSNev
Copy link
Collaborator

MSNev commented Apr 19, 2022

v2.8.1 of the AngularPlugin which uses AI v2.7.4 is now published
https://www.npmjs.com/package/@microsoft/applicationinsights-angularplugin-js/v/2.8.1

We plan to also release a v2.9.0 (which uses AI v2.8.0 shortly as well)

@MSNev
Copy link
Collaborator

MSNev commented Apr 19, 2022

@javier-caparo Can you upgrade to TypeScript 4.x? Or do you need to stay on TS 3.x?

@MSNev
Copy link
Collaborator

MSNev commented Apr 19, 2022

I have a v2.9.0 version of the angular plugin ready to publish, but I'm going to delay the release a little as it WILL require AI v2.8.0 (which has the above TS 4.x typing syntax) and it also uses new API's that only exist in 2.8.x so using a lock file to push back the version won't work.

@MSNev MSNev added the ts# compat Typescript version compatibility issue label Apr 19, 2022
@MSNev MSNev added this to the 2.8.1 milestone Apr 19, 2022
MSNev added a commit that referenced this issue Apr 19, 2022
- [BUG] Angular project doesn't build after install latest version v.2.8.0 #1807
@alexisHuaracMallqui
Copy link

hello, did you find any solution for the versions that use typescript 3.x ?

@MSNev
Copy link
Collaborator

MSNev commented Apr 19, 2022

Yes, the PR #1810 fixes the issue but GitHub and DevOps are having issues talking with each other -- which is blocking merging the PR. Once the PR is merged we are planning to release a v2.8.1 with the fix later this week.

@cmonzon44
Copy link
Author

during the fix isn't available, i set in my package.json explicit version : "@microsoft/applicationinsights-web": "2.7.4",

MSNev added a commit that referenced this issue Apr 20, 2022
- [BUG] Angular project doesn't build after install latest version v.2.8.0 #1807
MSNev added a commit that referenced this issue Apr 20, 2022
- [BUG] Angular project doesn't build after install latest version v.2.8.0 #1807
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Apr 20, 2022
@FabioColan
Copy link

Hello @MSNev , is going to work on some solution for TypeScript 3.x

@MSNev
Copy link
Collaborator

MSNev commented Apr 25, 2022

We released the following on Friday April, 22nd, both (should) work with TypeScript 3.x and 4.x

  • The Angular11 v2.7.1 uses ApplicationInsights v2.7.4, we are not planning on updating this to v2.8.x (or later), this was published to address the issue caused by the ApplicationInsights v2.8.x release and the package.json scoping.
  • Angular13 v2.9.0 uses ApplicationInsights v2.8.1

The TypeScript 3.x issue exists with Applicaiton Insights v2.8.0

@MSNev MSNev removed waiting - CDN deployment fixed - waiting release PR Committed and waiting deployment labels Apr 27, 2022
@MSNev
Copy link
Collaborator

MSNev commented Apr 27, 2022

v2.8.1 is now fully deployed

@MSNev
Copy link
Collaborator

MSNev commented Apr 27, 2022

Rolled back CDN to v2.7.4 due to #1822

@MSNev MSNev reopened this Apr 27, 2022
MSNev added a commit that referenced this issue Apr 30, 2022
- [BUG] Angular project doesn't build after install latest version v.2.8.0 #1807
MSNev added a commit that referenced this issue Apr 30, 2022
* Update version.json (#1767)

* [Release] Increase version to 2.7.4 (#1770)

- Updates React Plugin to v3.2.4 (with v2.7.4 as dependency)
- Updates React Native Plugin to 2.4.4 (with v2.7.4 as dependency)
- Updates Chrome Debug Extension to 0.2.4

This release is primarily a performance improvement release where we will now use any built in (or provided polyfill) function
over the internal polyfills for

- String trim()
- String endsWith()
- String startsWith()
- Additional Date toISOString()
- Array isArray()
- Array indexOf()
- Array map()
- Array reduce()
- Object freeze()
- Object seal()

* remove article link in the ReadMe (#1771)

* remove article links

* fix readme error

* Add custom properties argument to useTrackMetric (#1779)

* Merge remote-tracking branch 'upstream/beta' into MSNev/MergeBetaToMaster (#1791)

* Update version update script to support default "next" release version (major/minor) not just patch (#1756) (#1757)

* Merge [master] branch to [beta] and Enable GitHub Actions on [beta] branch (#1762)

* Update version update script to support default "next" release version (major/minor) not just patch (#1756)

* Additional Performance enhancements to use provided functions rather than internal polyfill's (#1758)

* [BUG] 2.7.4-nightly.2202-03 builds have a bug where objKeys() is not returning the keys #1763 (#1764)

* Enable GitHub Actions on [beta] branch

* Beta Part 1: Part of Mega Dynamic Load/Unload support (#1766)

- Refactor TelemetryPluginChain ready to start supporting load/unload
- Move TelemetryInitializer to BaseCore
- add getPlugin (will be used for remove)
- Address Channel flush issue

* Merge remote-tracking branch 'upstream/master' into beta (#1772)

* Additional Performance enhancements to use provided functions rather than internal polyfill's (#1758)

* [BUG] 2.7.4-nightly.2202-03 builds have a bug where objKeys() is not returning the keys #1763 (#1764)

* Update version.json (#1767)

* [Release] Increase version to 2.7.4 (#1770)

- Updates React Plugin to v3.2.4 (with v2.7.4 as dependency)
- Updates React Native Plugin to 2.4.4 (with v2.7.4 as dependency)
- Updates Chrome Debug Extension to 0.2.4

This release is primarily a performance improvement release where we will now use any built in (or provided polyfill) function
over the internal polyfills for

- String trim()
- String endsWith()
- String startsWith()
- Additional Date toISOString()
- Array isArray()
- Array indexOf()
- Array map()
- Array reduce()
- Object freeze()
- Object seal()

* [Beta] Keep version.json next as minor and resync shrinkwrap
- Fix merge issue

* Beta Part 2: Part of Mega Dynamic Load/Unload support (#1768)

- Add Event Namespace support
- Minification of constant values
- Add part of the unload functionality (required for unified `teardown()` functionality)

* Beta Part 3: Part of Mega Dynamic Load/Unload support (#1780)

* Beta Part 3: Part of Mega Dynamic Load/Unload support
- Add Core SDK Unload support

* Fix telemetry chain for null and undefined

* Beta Part 4: Part of Mega Dynamic Load/Unload support (#1781)

* Beta Part 4: Part of Mega Dynamic Load/Unload support
- Fix function typing issues
- Update Analytics Extension to start supporting teardown / unload (more tests required)
- Adds namespace option to instrumentation hooks (for debugging teardown issues)
- Update AITest Class to log and optionally assert events and hooks that have not been removed
- Add Update callback when plugins are added / removed (will be extended for config updates)
- Some minor minification improvements

* Update comments

* Add missing enum definition

* Update Sender tests

* Beta Part 5: Part of Mega Dynamic Load/Unload support (#1782)

- Add Missing Exports
- AnalyticsPlugin: Implement teardown and initial test validation
- Dependencies Plugin: Implement teardown and initial test validation
- Add flush() to IAppInsightsCore

* AI Beta: Minor bug fixes and additional debug info (#1787)

* Lint fixes: Enable Automatic formatting fixes (#1788)

* Beta Part 6: Part of Mega Dynamic Load/Unload support (#1782) (#1789)

- Add basic minimal unload / teardown support to all remaining components
- Update rollup cleanup dependencies

* Beta: Component Governance Updates to address known dependency issues (#1790)

* Master Minification Improvements (#1793)

* Master Minification Improvements
- Remove Generated classes
- And Convert to interfaces rather than classes

* Update version.json so next is a minor release

* Minification - Change to only use const enums internally (#1796)

- Remove Angular config from CodeQL

* More Common Minification Updates (#1798)

- SeverityLevel => const enum
- RequestHeaders
- TraceParent

* Enable fetch automatic dependency tracking by default (#1468)

* Finalize and Update the processTelemetry helper functions (#1805)

* [Release] Increase version to v2.8.0 (#1806)

* [BUG] Adding new on-by-default telemetry is a breaking change, and should involve a major version bump #1808 (#1809)

* v2.8.0 has incompatible TypeScript 3.x type declaration (#1810)

- [BUG] Angular project doesn't build after install latest version v.2.8.0 #1807

* [BUG] Browser exceptions are no longer automatically tracked after 2.8.0 #1812 (#1815)

* [Release] Increase version to 2.8.1 (#1816)

* [BUG] v2.8.1 with a Hosted IE environment fails to initialize for a hosted instance of IE #1822 (#1824)

[BUG] IE8 Support was broken by several components #1823

* [Release] Increase version to 2.7.4 (#1770)

- Updates React Plugin to v3.2.4 (with v2.7.4 as dependency)
- Updates React Native Plugin to 2.4.4 (with v2.7.4 as dependency)
- Updates Chrome Debug Extension to 0.2.4

This release is primarily a performance improvement release where we will now use any built in (or provided polyfill) function
over the internal polyfills for

- String trim()
- String endsWith()
- String startsWith()
- Additional Date toISOString()
- Array isArray()
- Array indexOf()
- Array map()
- Array reduce()
- Object freeze()
- Object seal()

* Merge remote-tracking branch 'upstream/beta' into MSNev/MergeBetaToMaster (#1791)

* Update version update script to support default "next" release version (major/minor) not just patch (#1756) (#1757)

* Merge [master] branch to [beta] and Enable GitHub Actions on [beta] branch (#1762)

* Update version update script to support default "next" release version (major/minor) not just patch (#1756)

* Additional Performance enhancements to use provided functions rather than internal polyfill's (#1758)

* [BUG] 2.7.4-nightly.2202-03 builds have a bug where objKeys() is not returning the keys #1763 (#1764)

* Enable GitHub Actions on [beta] branch

* Beta Part 1: Part of Mega Dynamic Load/Unload support (#1766)

- Refactor TelemetryPluginChain ready to start supporting load/unload
- Move TelemetryInitializer to BaseCore
- add getPlugin (will be used for remove)
- Address Channel flush issue

* Merge remote-tracking branch 'upstream/master' into beta (#1772)

* Additional Performance enhancements to use provided functions rather than internal polyfill's (#1758)

* [BUG] 2.7.4-nightly.2202-03 builds have a bug where objKeys() is not returning the keys #1763 (#1764)

* Update version.json (#1767)

* [Release] Increase version to 2.7.4 (#1770)

- Updates React Plugin to v3.2.4 (with v2.7.4 as dependency)
- Updates React Native Plugin to 2.4.4 (with v2.7.4 as dependency)
- Updates Chrome Debug Extension to 0.2.4

This release is primarily a performance improvement release where we will now use any built in (or provided polyfill) function
over the internal polyfills for

- String trim()
- String endsWith()
- String startsWith()
- Additional Date toISOString()
- Array isArray()
- Array indexOf()
- Array map()
- Array reduce()
- Object freeze()
- Object seal()

* [Beta] Keep version.json next as minor and resync shrinkwrap
- Fix merge issue

* Beta Part 2: Part of Mega Dynamic Load/Unload support (#1768)

- Add Event Namespace support
- Minification of constant values
- Add part of the unload functionality (required for unified `teardown()` functionality)

* Beta Part 3: Part of Mega Dynamic Load/Unload support (#1780)

* Beta Part 3: Part of Mega Dynamic Load/Unload support
- Add Core SDK Unload support

* Fix telemetry chain for null and undefined

* Beta Part 4: Part of Mega Dynamic Load/Unload support (#1781)

* Beta Part 4: Part of Mega Dynamic Load/Unload support
- Fix function typing issues
- Update Analytics Extension to start supporting teardown / unload (more tests required)
- Adds namespace option to instrumentation hooks (for debugging teardown issues)
- Update AITest Class to log and optionally assert events and hooks that have not been removed
- Add Update callback when plugins are added / removed (will be extended for config updates)
- Some minor minification improvements

* Update comments

* Add missing enum definition

* Update Sender tests

* Beta Part 5: Part of Mega Dynamic Load/Unload support (#1782)

- Add Missing Exports
- AnalyticsPlugin: Implement teardown and initial test validation
- Dependencies Plugin: Implement teardown and initial test validation
- Add flush() to IAppInsightsCore

* AI Beta: Minor bug fixes and additional debug info (#1787)

* Lint fixes: Enable Automatic formatting fixes (#1788)

* Beta Part 6: Part of Mega Dynamic Load/Unload support (#1782) (#1789)

- Add basic minimal unload / teardown support to all remaining components
- Update rollup cleanup dependencies

* Beta: Component Governance Updates to address known dependency issues (#1790)

* Master Minification Improvements (#1793)

* Master Minification Improvements
- Remove Generated classes
- And Convert to interfaces rather than classes

* Update version.json so next is a minor release

* Minification - Change to only use const enums internally (#1796)

- Remove Angular config from CodeQL

* More Common Minification Updates (#1798)

- SeverityLevel => const enum
- RequestHeaders
- TraceParent

* Enable fetch automatic dependency tracking by default (#1468)

* Finalize and Update the processTelemetry helper functions (#1805)

* [Release] Increase version to v2.8.0 (#1806)

* [BUG] Adding new on-by-default telemetry is a breaking change, and should involve a major version bump #1808 (#1809)

* v2.8.0 has incompatible TypeScript 3.x type declaration (#1810)

- [BUG] Angular project doesn't build after install latest version v.2.8.0 #1807

* [BUG] Browser exceptions are no longer automatically tracked after 2.8.0 #1812 (#1815)

* [Release] Increase version to 2.8.1 (#1816)

* Fix merge Issues -- full compare with master
- Update version.json so next beta will be 3.0.0

* Set next beta release as major

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>
Co-authored-by: Simo Nurmi <simo.aleksi.nurmi@gmail.com>
Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
@MSNev
Copy link
Collaborator

MSNev commented May 17, 2022

v2.8.3 is now fully deployed to the CDN

@MSNev MSNev closed this as completed May 17, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released - NPM ts# compat Typescript version compatibility issue
Projects
None yet
Development

No branches or pull requests

5 participants