Update to use performanceNavigationTiming interface for supported bro… #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
previously approved these changes
Sep 4, 2019
...s/applicationinsights-analytics-js/src/JavaScriptSDK/Telemetry/PageViewPerformanceManager.ts
Show resolved
Hide resolved
markwolff
reviewed
Sep 4, 2019
| var request = DateTimeUtils.GetDuration(timing.requestStart, timing.responseStart); | ||
| var response = DateTimeUtils.GetDuration(timing.responseStart, timing.responseEnd); | ||
| var dom = DateTimeUtils.GetDuration(timing.responseEnd, timing.loadEventEnd); | ||
| if (navigationTiming || timing) { |
There was a problem hiding this comment.
can this line be removed? and replace the } else { with an else if
There was a problem hiding this comment.
There's chance that neither of these two exists, then it will do nothing. So this check needs to be kept?
hectorhdzg
reviewed
Sep 4, 2019
...s/applicationinsights-analytics-js/src/JavaScriptSDK/Telemetry/PageViewPerformanceManager.ts
Show resolved
Hide resolved
hectorhdzg
reviewed
Sep 4, 2019
...s/applicationinsights-analytics-js/src/JavaScriptSDK/Telemetry/PageViewPerformanceManager.ts
Show resolved
Hide resolved
markwolff
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…wser