Tslint #1041
Merged
Tslint #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiao-lix
requested review from
markwolff,
hectorhdzg and
ramthi
and removed request for
markwolff
markwolff
reviewed
Sep 10, 2019
hectorhdzg
reviewed
Sep 11, 2019
| @@ -11,7 +11,6 @@ | |||
| "noEmitHelpers": true, | |||
| "alwaysStrict": true, | |||
| "declaration": true, | |||
| "declarationMap": true, | |||
There was a problem hiding this comment.
Why are you removing declarationMap?
hectorhdzg
reviewed
Sep 11, 2019
hectorhdzg
reviewed
Sep 11, 2019
hectorhdzg
reviewed
Sep 11, 2019
| var uid; | ||
| let storage: Storage = null; | ||
| let fail: boolean; | ||
| let uid: Date; |
There was a problem hiding this comment.
uid is a Date?, the name make it sound like some kind of ID
hectorhdzg
reviewed
Sep 11, 2019
markwolff
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rush lint